How do *you* review code?
Does it go something like this?
a) Checkout the PR
b) Scan through the code, looking for obvious s**t
c) Approve it
a) Checkout the PR
b) Scan through the code, looking for obvious s**t
c) Approve it
Thats about it, right? Mind you, if you’re feeling particularly testy, -b- above might turn into
“Scan through the code, and find something to criticize”
but that’s really about it.
“Scan through the code, and find something to criticize”
but that’s really about it.
 |
| /via http://geek-and-poke.com |
This isn’t really because you’re a bad person. Odds are, you’re in the middle of one of two things
Code Reviews Take Time
It’s true. And there really isn’t much that you can do about it. That said, a different way of saying this is There is no short-cut to Quality.
You want software that doesn’t suck? Well, that’s going to take time, no way around it. If your tech-lead/PM/ProdMgr doesn’t get it, either help them get it, or find a new job (•). At some point, s**t is going to break, and, well, you don’t want to be in the blast radius…
It’s true. And there really isn’t much that you can do about it. That said, a different way of saying this is There is no short-cut to Quality.
You want software that doesn’t suck? Well, that’s going to take time, no way around it. If your tech-lead/PM/ProdMgr doesn’t get it, either help them get it, or find a new job (•). At some point, s**t is going to break, and, well, you don’t want to be in the blast radius…
#CowboyDeveloper Hates Code Reviews
This is a wee bit trickier. If you’ve got one of those, they know that their s**t doesn’t stink, their code is brilliant, and, well, you just don’t get it.
They’ll dump their impenetrable code on you — code that is either impenetrable ‘cos it’s bad, or impenetrable because they are SoClever™ — either way you’re now stuck arguing with a #CowboyDeveloper (••).
Even worse, if they’re in a position of authority, you, literally, can’t win — see if you can find a new job (•)
This is a wee bit trickier. If you’ve got one of those, they know that their s**t doesn’t stink, their code is brilliant, and, well, you just don’t get it.
They’ll dump their impenetrable code on you — code that is either impenetrable ‘cos it’s bad, or impenetrable because they are SoClever™ — either way you’re now stuck arguing with a #CowboyDeveloper (••).
Even worse, if they’re in a position of authority, you, literally, can’t win — see if you can find a new job (•)
Mind you, if it’s not one of the above, then, well, whats your excuse?
(•) If you are in a position that you can find a new job, that is. If not, see if you can get yourself into that position…
(••) Never get in an argument with a #CowboyDeveloper, you’ll get frustrated, and, besides, the #CowboyDeveloper likes it (with apologies to George Bernard Shaw)
(••) Never get in an argument with a #CowboyDeveloper, you’ll get frustrated, and, besides, the #CowboyDeveloper likes it (with apologies to George Bernard Shaw)
Comments